Adds support for render detect for Android 6+#2027
Merged
bidetofevil merged 2 commits intomainfrom Mar 13, 2025
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
bidetofevil
force-pushed
the
hho/add-legacy-render
branch
from
c0ca9bf to
fae07ea
Compare
bidetofevil
force-pushed
the
hho/add-legacy-render
branch
from
fae07ea to
a22e3a9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2027 +/- ##
==========================================
+ Coverage 85.23% 85.37% +0.13%
==========================================
Files 464 466 +2
Lines 10512 10523 +11
Branches 1556 1558 +2
==========================================
+ Hits 8960 8984 +24
+ Misses 875 858 -17
- Partials 677 681 +4
🚀 New features to boost your workflow:
|
Contributor
Author
bidetofevil
force-pushed
the
hho/add-legacy-render
branch
from
a22e3a9 to
4ba108f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Use an alternate way to detect that a frame was been delivered that works for Android 12 and Android 6 to 9. Implement a new
DrawEventEmitterthat uses this alternative method, and supply when the other one doesn't work.All the unit tests have been updated to reflect this new reality, but the integration tests don't check for hardware based render events. But with this, we may be able to test this by simulating this, so stay tuned!
Testing
Manually tested for a subset of real devices/apps. Will test it more comprehensively.